Skip to content

Commit

Permalink
only deploy metadata when needed
Browse files Browse the repository at this point in the history
Issue: ZENKO-4414
  • Loading branch information
Kerkesni committed Jan 28, 2025
1 parent 0a7a912 commit 8e060ea
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 3 deletions.
1 change: 1 addition & 0 deletions .github/actions/deploy/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ runs:
shell: bash
run: bash deploy-metadata.sh
working-directory: ./.github/scripts/end2end
if: ${{ env.ENABLE_RING_TESTS == 'true' }}
- name: End-to-end configuration
shell: bash
run: bash configure-e2e.sh "end2end" ${E2E_IMAGE_NAME}:${E2E_IMAGE_TAG} "default"
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/end2end.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ env:
GCP_BACKEND_SERVICE_KEY: ${{ secrets.GCP_BACKEND_SERVICE_KEY }}
GCP_BACKEND_SERVICE_EMAIL: ${{ secrets.GCP_BACKEND_SERVICE_EMAIL }}
# Enable this for Ring tests
ENABLE_RING_TESTS: "true"
ENABLE_RING_TESTS: "false"
RING_S3C_ACCESS_KEY: accessKey1
RING_S3C_SECRET_KEY: verySecretKey1
RING_S3C_ENDPOINT: http://s3c.local:8000
Expand Down Expand Up @@ -553,6 +553,9 @@ jobs:
needs: [build-kafka, build-test-image]
runs-on:
- ubuntu-22.04-8core
env:
ENABLE_RING_TESTS: "true"
GIT_ACCESS_TOKEN: ${{ secrets.GIT_ACCESS_TOKEN }}
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -568,8 +571,6 @@ jobs:
registry: ghcr.io
- name: Deploy Zenko
uses: ./.github/actions/deploy
env:
GIT_ACCESS_TOKEN: ${{ secrets.GIT_ACCESS_TOKEN }}
- name: Run backbeat end to end tests
run: bash run-e2e-test.sh "end2end" ${E2E_IMAGE_NAME}:${E2E_IMAGE_TAG} "backbeat" "default"
working-directory: ./.github/scripts/end2end
Expand Down
6 changes: 6 additions & 0 deletions tests/zenko_tests/e2e_config/locations.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#!/usr/bin/env python

import logging
import os

_log = logging.getLogger("end2end configuration")

Expand All @@ -11,6 +12,11 @@ def create_location(client, uuid, location):
:param uuid: zenko instance uuid
:param location: location details
"""

ENABLE_RING_TESTS = os.environ['ENABLE_RING_TESTS']
if ENABLE_RING_TESTS == "false" and location["locationType"] == "location-scality-ring-s3-v1":
return

try:
Location_V1 = client.get_model('location-v1')
if "bootstrapList" not in location["details"]:
Expand Down

0 comments on commit 8e060ea

Please sign in to comment.