Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Metadata in Backbeat tests #2610

Open
wants to merge 3 commits into
base: development/9.0
Choose a base branch
from

Conversation

Kerkesni
Copy link
Contributor

@Kerkesni Kerkesni commented Jan 10, 2025

  • Deploy a metadata setup in a separate CI job
  • Add a minimal test for queue populator that uses the metadata backend

Issue: BB-496

@bert-e
Copy link
Contributor

bert-e commented Jan 10, 2025

Hello kerkesni,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jan 10, 2025

Incorrect fix version

The Fix Version/s in issue BB-496 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.0.0

Please check the Fix Version/s of BB-496, or the target
branch of this pull request.

@bert-e
Copy link
Contributor

bert-e commented Jan 10, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.64%. Comparing base (287b942) to head (b5df0cd).

Additional details and impacted files

Impacted file tree graph

see 12 files with indirect coverage changes

Components Coverage Δ
Bucket Notification 75.37% <ø> (ø)
Core Library 78.77% <ø> (+3.02%) ⬆️
Ingestion 69.24% <ø> (ø)
Lifecycle 76.83% <ø> (+0.68%) ⬆️
Oplog Populator 85.06% <ø> (ø)
Replication 58.56% <ø> (+0.77%) ⬆️
Bucket Scanner 85.60% <ø> (ø)
@@                 Coverage Diff                 @@
##           development/9.0    #2610      +/-   ##
===================================================
+ Coverage            71.11%   72.64%   +1.52%     
===================================================
  Files                  201      201              
  Lines                13334    13334              
===================================================
+ Hits                  9483     9687     +204     
+ Misses                3841     3637     -204     
  Partials                10       10              
Flag Coverage Δ
api:retry 9.52% <ø> (ø)
api:routes 9.34% <ø> (ø)
bucket-scanner 85.60% <ø> (ø)
e2e 9.68% <ø> (?)
ingestion 12.29% <ø> (+<0.01%) ⬆️
lib 7.36% <ø> (ø)
lifecycle 18.82% <ø> (ø)
notification 1.07% <ø> (ø)
replication 18.63% <ø> (+0.03%) ⬆️
unit 48.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bert-e
Copy link
Contributor

bert-e commented Jan 10, 2025

Conflict

There is a conflict between your branch improvement/BB-496 and the
destination branch development/9.0.

Please resolve the conflict on the feature branch (improvement/BB-496).

git fetch && \
git checkout origin/improvement/BB-496 && \
git merge origin/development/9.0

Resolve merge conflicts and commit

git push origin HEAD:improvement/BB-496

@Kerkesni Kerkesni force-pushed the improvement/BB-496 branch 2 times, most recently from c4ed1bd to f879fa3 Compare January 10, 2025 15:59
@bert-e
Copy link
Contributor

bert-e commented Jan 10, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@Kerkesni Kerkesni force-pushed the improvement/BB-496 branch 5 times, most recently from 67881fa to f39158e Compare January 14, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants