Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HD-3988: range matrix less io #17

Draft
wants to merge 7 commits into
base: development/1.0
Choose a base branch
from
Draft

HD-3988: range matrix less io #17

wants to merge 7 commits into from

Conversation

liaud
Copy link

@liaud liaud commented Jan 8, 2025

No description provided.

liaud added 4 commits December 18, 2024 11:44
@liaud
range matrix: Unify names and adds small comments.
b2de5f7
@liaud
Introduce a new API for Encode,Decode matrix variants.
313d454 
This new API handle more efficiently sub range residing inside a
single encoding group.

The previous DecodeMatrix has been split into 3 functions that must
be used in different cases:

- LinearizeMatrix: A function that take data fragments and linearize them.
  In contrary to the old 'decode_fast' there is no more requirement on the
  number of provided data fragments.

- DecodeMatrix: This function expect as many fragment as the schema requires.
  It will both reconstruct the missing data fragments if any and linearize
  the data.

- ValidateFragmentMatrix: Is used to check a retrieve fragment. This is useful to
  detect corruption cases before giving the fragments to LinearizeMatrix.

In addition, GetRangeMatrix has been updated to require the minimum amount
of fragments when the requested range span a single group.

Matrix functions directly takes the RangeMatrix as an argument to reflect they
are part of the same API group.
@liaud
Do not validate checksum multiple times.
e8c045e 
We expect ValidateFragment to be called once beforehand.
This avoid doing redundant checksum checks.
@liaud
Rename a few variables for consistency with the rest of the codebase.
773014a
@bert-e
Copy link

bert-e commented Jan 8, 2025

Hello liaud,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link

bert-e commented Jan 8, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoit-a benoit-a Awaiting requested review from benoit-a

@bertranddemiddelaer bertranddemiddelaer Awaiting requested review from bertranddemiddelaer

@lamphamsy lamphamsy Awaiting requested review from lamphamsy

@vietnscality vietnscality Awaiting requested review from vietnscality

@fferrandis fferrandis Awaiting requested review from fferrandis

@ftalbart ftalbart Awaiting requested review from ftalbart

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liaud @bert-e