Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PTFE-1959 support deletion of non-existent vsphere vm #667

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

tcarmet
Copy link
Contributor

@tcarmet tcarmet commented Aug 29, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.72%. Comparing base (2d4bb12) to head (a6819cd).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #667      +/-   ##
==========================================
+ Coverage   86.66%   86.72%   +0.05%     
==========================================
  Files          34       34              
  Lines        1425     1431       +6     
==========================================
+ Hits         1235     1241       +6     
  Misses        190      190              
Flag Coverage Δ
api 64.91% <14.28%> (-0.21%) ⬇️
unit 67.43% <14.28%> (-0.22%) ⬇️
vsphere 39.41% <100.00%> (-1.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tcarmet tcarmet marked this pull request as ready for review August 29, 2024 21:06
@tcarmet tcarmet requested a review from a team as a code owner August 29, 2024 21:06
@tcarmet tcarmet merged commit 3d04d0b into main Aug 30, 2024
13 checks passed
@tcarmet tcarmet deleted the vsphere-vm-not-found branch August 30, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants