Improvement/vltclt 37 remove arsenal dep

[williamlardier]

Remove arsenal from the prod dependencies, as it is only used to check errors (internal error, mostly), that can be stored as a const.
The main advantage being the decrease of the build duration, arsenal requires to build multiple modules, taking up to 5~10min every time in some CIs, depending on the load.

[bert-e]

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

[bert-e]

Incorrect fix version

The Fix Version/s in issue VLTCLT-37 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 8.3.16

Please check the Fix Version/s of VLTCLT-37, or the target
branch of this pull request.

[tmacro]

NPM is indicating that this package has been moved to @smithy/signature-v4

[williamlardier]

Done here: 9fe22ac

[tmacro]

Adding the async tag changes the return to a Promise, which in the case of signer.sign throwing would result in a UnhandlePromiseRejection and crash the process.

I'd suggest adding a _signRequest helper that is async and then using then and catch in request.
Something like:

async _signRequest(iamAuthenticate, req, options) 

That could then be used in request like

this._signRequest(iamAuthenticate, req, options)
    .catch(callback)
    .then(() => {
          ...
    });

[williamlardier]

The helper was created, and the logic structure was reworked a bit to keep a flat function:
1ce5626

[KazToozs]

lgtm

[bert-e]

Incorrect fix version

The Fix Version/s in issue VLTCLT-37 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 8.3.17

Please check the Fix Version/s of VLTCLT-37, or the target
branch of this pull request.

[bert-e]

Incorrect fix version

The Fix Version/s in issue VLTCLT-37 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 8.3.18

Please check the Fix Version/s of VLTCLT-37, or the target
branch of this pull request.

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• 2 peers

[williamlardier]

/approve

[bert-e]

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

• ✔️ development/8.3

The following branches will NOT be impacted:

• development/6.4
• development/7.10
• development/7.4
• development/8.2

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

• Any commit you add on the source branch will trigger a new cycle after the
  current queue is merged.
• Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

[bert-e]

I have successfully merged the changeset of this pull request
into targetted development branches:

• ✔️ development/8.3

The following branches have NOT changed:

• development/6.4
• development/7.10
• development/7.4
• development/8.2

Please check the status of the associated issue VLTCLT-37.

Goodbye williamlardier.