Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scx_utils: specify libbpf-sys to 1.4.6, bump libbpf-rs versions #1087

Closed
wants to merge 0 commits into from

Conversation

etsal
Copy link
Contributor

@etsal etsal commented Dec 9, 2024

The libbpf-sys package for the Rust schedulers has buggy behavior for versions 1.4.1 and 1.5.0: 1.4.1 crashes when linking multiple BPF objects, while using 1.5.0 causes all Rust schedulers to crash (#1074 #1015). Pin libbpf-sys 1.4.6 to avoid either problem. To use 1.4.6, also update libbbpf-rs to the most recent version.

@etsal etsal changed the title specify libbpf-sys to 1.4.6, bump libbpf-rs versions scx_utils: specify libbpf-sys to 1.4.6, bump libbpf-rs versions Dec 9, 2024
@likewhatevs
Copy link
Contributor

I kind of think we should set all instances of libbpf-rs, libbpf-sys and libbpf-cargo to the same version everywhere.

That being said, I tried doing exactly that (using 1.4.6 iirc) and 1.5.0 was still being pulled in somehow during cargo install (which is like cargo build without a Cargo.lock) despite 1.5.0 being absent from cargo-tree so idk...

@etsal
Copy link
Contributor Author

etsal commented Dec 10, 2024

Did you try libbpf-sys = '1.4.6', or libbpf-sys = '=1.4.6'? If it was the latter then it's very weird, it's supposed to be pinning the semantic version. The former is just a preferred version so Cargo is allowed to pull a more recent one.

@etsal etsal force-pushed the etsal/bump-libbpf-rs branch 2 times, most recently from 0ea3a90 to 3be0d2a Compare December 10, 2024 15:20
@etsal etsal closed this Dec 10, 2024
@etsal etsal force-pushed the etsal/bump-libbpf-rs branch from 3be0d2a to 7e3d61f Compare December 10, 2024 15:33
@etsal etsal deleted the etsal/bump-libbpf-rs branch December 10, 2024 15:41
@etsal etsal restored the etsal/bump-libbpf-rs branch December 10, 2024 15:41
@likewhatevs
Copy link
Contributor

Did you try libbpf-sys = '1.4.6', or libbpf-sys = '=1.4.6'? If it was the latter then it's very weird, it's supposed to be pinning the semantic version. The former is just a preferred version so Cargo is allowed to pull a more recent one.

the latter, after seeing that not work I just added cargo install --locked to the readme instead of trying to get cargo install without --locked to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants