Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scx_utils: expose possible and online cpus from Topology #1132

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

evanrittenhouse
Copy link

This exposes possible and online CPUs to schedulers.

Related to #721.

Copy link
Contributor

@htejun htejun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that topology.span is the online CPUs, it's rather odd to add separate online mask. Maybe just add topology.span_possible?

@evanrittenhouse
Copy link
Author

Given that topology.span is the online CPUs, it's rather odd to add separate online mask. Maybe just add topology.span_possible?

Ah, I had this in draft as I was still exploring, sorry about that! Does it make sense to move the span = cpus_online() call into instantiate, like here?

@htejun
Copy link
Contributor

htejun commented Dec 31, 2024

Given that topology.span is the online CPUs, it's rather odd to add separate online mask. Maybe just add topology.span_possible?

Ah, I had this in draft as I was still exploring, sorry about that! Does it make sense to move the span = cpus_online() call into instantiate, like here?

Hmm.. are there reasons it can't be done in new()? instantiate() is there to post process the collected topology information. I don't know why online / possible cpumasks would need to be processed there.

@evanrittenhouse
Copy link
Author

Given that topology.span is the online CPUs, it's rather odd to add separate online mask. Maybe just add topology.span_possible?

Ah, I had this in draft as I was still exploring, sorry about that! Does it make sense to move the span = cpus_online() call into instantiate, like here?

Hmm.. are there reasons it can't be done in new()? instantiate() is there to post process the collected topology information. I don't know why online / possible cpumasks would need to be processed there.

Sure thing. I still need to figure out how to integrate the possible cpumasks into the schedulers, though maybe that could/should be a followup

This exposes possible CPUs, in addition to the existing online CPUs, to
schedulers.

Related to sched-ext#721.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants