scx_utils: cleanup gpu topology part #1211
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arighi
requested changes
Jan 17, 2025
devnexen
force-pushed
the
gpu_topology_simpl
branch
from
5adebfa to
413f0d1
Compare
hodgesds
reviewed
Jan 19, 2025
rust/scx_utils/src/topology.rs
Outdated
| @@ -270,9 +270,9 @@ impl Topology { | |||
| #[cfg(feature = "gpu-topology")] | |||
| pub fn gpus(&self) -> BTreeMap<GpuIndex, &Gpu> { | |||
| let mut gpus = BTreeMap::new(); | |||
| for (_, node) in &self.nodes { | |||
| for node in self.nodea.values() { | |||
There was a problem hiding this comment.
I think I just forgot to test gpu-topology build before committing
devnexen
force-pushed
the
gpu_topology_simpl
branch
from
413f0d1 to
705bff7
Compare
hodgesds
approved these changes
Jan 21, 2025
htejun
approved these changes
Jan 22, 2025
code using more modern construct to replace simple match patterns mostly, simplifying loops.
devnexen
force-pushed
the
gpu_topology_simpl
branch
from
705bff7 to
24d023c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code using more modern construct to replace simple match patterns
mostly, simplifying loops.