Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add table html tags and select controlled value #354

Merged
merged 5 commits into from
Dec 30, 2024
Merged

Conversation

schultek
Copy link
Owner

Description

Type of Change

  • ✨ New feature or improvement

Ready Checklist

  • I've read the Contribution Guide.
  • In case this PR changes one of the core packages, I've modified the respective CHANGELOG.md file using
    the semantic_changelog format.
  • I updated/added relevant documentation (doc comments with ///).
  • I added myself to the AUTHORS file (optional, if you want to).

Copy link

docs-page bot commented Dec 30, 2024

To view this pull requests documentation preview, visit the following URL:

docs.page/schultek/jaspr~354

Documentation is deployed and generated using docs.page.

Copy link

github-actions bot commented Dec 30, 2024

Package Version Report

The following packages have been updated:
jaspr : 0.16.2 -> 0.16.3
jaspr_builder : 0.16.2 -> 0.16.3
jaspr_cli : 0.16.2 -> 0.16.3
jaspr_test : 0.16.2 -> 0.16.3

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 75.80%. Comparing base (0d913ff) to head (ad28991).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
packages/jaspr/lib/src/components/html/table.dart 73.68% 10 Missing ⚠️
packages/jaspr/lib/src/components/html/other.dart 87.50% 1 Missing ⚠️
...pr/lib/src/server/adapters/head_scope_adapter.dart 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #354      +/-   ##
==========================================
+ Coverage   75.66%   75.80%   +0.14%     
==========================================
  Files         128      129       +1     
  Lines        5424     5481      +57     
==========================================
+ Hits         4104     4155      +51     
- Misses       1320     1326       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schultek schultek marked this pull request as ready for review December 30, 2024 19:49
@schultek schultek merged commit f184f1c into main Dec 30, 2024
4 of 5 checks passed
@schultek schultek deleted the feat/table-html branch December 30, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant