Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add logging endpoint for synapse devices #30

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

gilbert-sci
Copy link
Contributor

Summary

  • Adds logging.proto
    • Defines a log entry
    • Defines requests for logs
  • Adds GetLogs
  • Adds TailLogs

Discussion

  • Should we discriminate on the timestamp source? I just use google's timestamp here, but we might want to describe if it is monotonic or system time (since the current SciFi device doesn't have persistent system time)

Copy link
Collaborator

@antoniaelsen antoniaelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, tyvm!

In Nexus we use uint64 ns timestamps but I don't have strong opinions for synapse. Just worth noting in case we want consistency

@gilbert-sci
Copy link
Contributor Author

I can update it to be timestamp_ns, that is nice if that is what we prefer. I sometimes defer to the sec.nsec because more systems support it/matches how linux does time.

@gilbert-sci gilbert-sci merged commit dde787b into main Feb 12, 2025
2 checks passed
@gilbert-sci gilbert-sci deleted the gilbert/logging-api branch February 12, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants