New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[api] Revert peripheral to be clear on source type #31

Closed

gilbert-sci wants to merge 1 commit into main from gilbert/revert-periphs

Contributor

gilbert-sci commented Feb 13, 2025

Summary

From @polymerizedsage

I think I missed this while reviewing the API change, but these really should have stayed as separate peripheral types. There are no peripherals that support recording electrical AND optical data, so now the peripheral type doesnt actually convey information about what type of signal config should be provided.


          [api] Revert peripheral to be clear on source type

43a11d1

gilbert-sci requested review from antoniaelsen and polymerizedsage

February 13, 2025 21:13

gilbert-sci self-assigned this

gilbert-sci closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet