Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a builder class for CIF files #548

Merged
merged 9 commits into from
Sep 16, 2024
Merged

Add a builder class for CIF files #548

merged 9 commits into from
Sep 16, 2024

Commits on Sep 16, 2024

  1. Move common code into base class

    @jl-wynen
    jl-wynen committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    ac0bfd8 View commit details
    Browse the repository at this point in the history

  2. Use empty quotes for empty strings

    @jl-wynen
    jl-wynen committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    a30ed8b View commit details
    Browse the repository at this point in the history

  3. Add a CIF builder

    @jl-wynen
    jl-wynen committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    4afda6c View commit details
    Browse the repository at this point in the history

  4. Preserve existing comment

    @jl-wynen
    jl-wynen committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    1c57df2 View commit details
    Browse the repository at this point in the history

  5. Support authors in CIF

    @jl-wynen
    jl-wynen committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    fe08431 View commit details
    Browse the repository at this point in the history

  6. Handle reducers using builder pattern

    @jl-wynen
    jl-wynen committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    a2a7893 View commit details
    Browse the repository at this point in the history

  7. Document new CIF interface

    @jl-wynen
    jl-wynen committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    ddadd8e View commit details
    Browse the repository at this point in the history

  8. Fix typo

    @jl-wynen
    jl-wynen committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    59d3a31 View commit details
    Browse the repository at this point in the history

  9. Override comment in save_cif

    @jl-wynen
    jl-wynen committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    52469d8 View commit details
    Browse the repository at this point in the history