Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styling of diff interaction not working in modal #210

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Pilopa
Copy link
Contributor

@Pilopa Pilopa commented May 31, 2022

Proposed changes

The hunk styling in the review plugin did not work in fullscreen mode since the modal had been reworked to use react-portal.
The styling has been moved to the diff component of ui-components in #2047. This PR removes the obsolete and broken wrapper component and instead utilizes the newly created props of the diff view.

Your checklist for this pull request

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Contributor:

  • PR is well described and the description can be used as a commit message on squash
  • Related issues linked to PR if existing and labels set
  • Changelog entry file created in gradle/changelog

Reviewer:

  • The clean code principles are respected (CleanCode)
  • All new code/logic is implemented on the right spot / "Should this be done here?"
  • UI changes fits into the layout
  • The UI views / components are responsive (mobile views)
  • Correct translations are available

Checklist for branch merge request (not required for forks)

@Pilopa Pilopa added the bug Something isn't working label May 31, 2022
@Pilopa Pilopa changed the title use new diff view api and remove old wrapper Fix styling of diff interaction not working in modal May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants