Download, configure and launch collector #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrothrock
force-pushed
the
download-collector
branch
from
90f0ed6 to
9229bce
Compare
lancetarn
approved these changes
May 7, 2024
| 'collector_config_file' => '/tmp/scout_apm/config.yml', | ||
| 'collector_version' => '0.99.0', | ||
| 'monitored_logs' => [], | ||
| 'logs_reporting_endpoint' => 'https://otlp.telemetryhub.com:4317' |
There was a problem hiding this comment.
I think we'll want to create DNS for scoutapm.com, like otlp.scoutapm.com that we can still point at the TH ingest LB. Or whereever else we want. Obviously doesn't need to change now but just to say it out loud.
lancetarn
reviewed
May 7, 2024
| extract_collector | ||
| end | ||
|
|
||
| # TODO: Re-evaluate this? |
There was a problem hiding this comment.
What about it would you like to evaluate? This seems reasonable. Would you consider trying to package the collector binary into the gem? I feel like that is another option... I've seen worse.
There was a problem hiding this comment.
Ah sorry, I didn't clarify this much. This is in regards to the Assignment Branch Condition size and Rubocop
# rubocop:disable Metrics/AbcSize for the method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to download, configure and launch the otel-collector at Rails initialization.
This PR handles more of the happy path. Such as we are in a Rails environment (and not Sinatra for example), have access to the /tmp directory, can execute binaries within the /tmp directory, etc.
Additionally, due to brevity and the existing line count, additional and improved test coverage will occur in a separate PR.