New block merge

.github/workflows/pr-block-rules.yml

@@ -0,0 +1,20 @@
+name: PR Block Rules
+
+on:
+  pull_request:
+    types: [opened, edited]
+
+jobs:
+  comment-on-pr:
+    runs-on: ubuntu-latest
+
+    steps:
+    - name: Checkout code
+      uses: actions/checkout@v2
+
+    - name: Display block rules
+      run: |
+        RULES=$(cat ./block_creation_rules.md)
+        gh pr comment ${{ github.event.pull_request.number }} --body "$RULES"
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

block_creation_rules.md

@@ -0,0 +1,33 @@
+Hello there!  
+Thank you for contributing.
+
+Before merging, please ensure that each modified or newly created block meets the following requirements:
+
+**Concise List:**
+
+##### 1. The block does one thing.
+- For example, the `create_embed` block should only create an embed and not create a variable.
+
+##### 2. The block has warnings for crucial inputs.
+- For example, in the `get_user_by_id` block, the `id` field must include a warning, as it is crucial for the block to function as intended.
+
+##### 3. Each block has maximum customizability.
+
+##### 4. Inputs are error-proofed.
+- **DO NOT CREATE INPUTS WHERE YOU CAN TYPE CODE** (with the exception of the insert JS block).
+- Inputs should not cause errors, even when left empty.
+
+##### 5. Consistent design patterns.
+- Every block should be created in the same style.
+
+##### 6. Clear and descriptive titles.
+
+##### 7. Block modularity and reusability.
+- Ensure that blocks can connect with each other in various scenarios. For example, if two blocks have the `user` type, they should be usable in all user inputs.
+
+##### 8. Performance.
+
+##### 9. Consider user feedback.
+
+These rules will make app development easier, help eliminate pesky bugs, and simplify refactoring.
+

src/lib/blocks/Javascript/Loops.ts

@@ -15,10 +15,10 @@ const blocks: BlockDefinition[] = [
 		shape: BlockShape.Action,
 		inline: true,
 		colour: rgbToHex(91, 165, 91),
-		tooltip: "Repeat x times",
+		tooltip: "Repeats the code inside the given ammount of times.",
 		helpUrl: "",
 		code: (args) => {
-			return `for (let i = 0; i < ${args.VALUE === ""? "0" : args.VALUE}; i++) {\n${args.INPUT === ""? "" : args.INPUT}\n}`;
+			return `for (let i = 0; i < ${args.VALUE === "" ? "0" : args.VALUE}; i++) {\n${args.INPUT === "" ? "" : args.INPUT}\n}`;
 		}
 	},
 	{
@@ -35,10 +35,10 @@ const blocks: BlockDefinition[] = [
 		shape: BlockShape.Action,
 		inline: true,
 		colour: rgbToHex(91, 165, 91),
-		tooltip: "Repeat while",
+		tooltip: "Repeats the code inside until/while the condition is met.",
 		helpUrl: "",
 		code: (args) => {
-			return `while (${args.WHILE === "while" ? "" : "!"}( ${args.CONDITION === ""? "false" : args.CONDITION} )) {\n${args.INPUT === ""? "" : args.INPUT}\n}`;
+			return `while (${args.WHILE === "while" ? "" : "!"}( ${args.CONDITION === "" ? "false" : args.CONDITION} )) {\n${args.INPUT === "" ? "" : args.INPUT}\n}`;
 		}
 	},
 	{
@@ -60,10 +60,10 @@ const blocks: BlockDefinition[] = [
 		tooltip: "For loop",
 		helpUrl: "",
 		code: (args) => {
-			if(args.VARIABLE === "") return "";
-			let variable = `let ${args.VARIABLE} =${args.START ===""? "0" : args.START}`;
-			let condition = `${args.VARIABLE} < ${args.END === ""? "0" : args.END}`;
-			let step = `${args.VARIABLE} += ${args.STEP ===""? "0" : args.STEP}}`;
+			if (args.VARIABLE === "") return "";
+			const variable = `let ${args.VARIABLE} =${args.START === "" ? "0" : args.START}`;
+			const condition = `${args.VARIABLE} < ${args.END === "" ? "0" : args.END}`;
+			const step = `${args.VARIABLE} += ${args.STEP === "" ? "0" : args.STEP}}`;
 			if (args.VARIABLE === "") {
 				const varName = salt(10);
 				return `for(let vk${varName} = 0; false; vk${varName}+= 0) {}`;
@@ -82,7 +82,7 @@ const blocks: BlockDefinition[] = [
 		shape: BlockShape.Action,
 		inline: true,
 		colour: rgbToHex(91, 165, 91),
-		tooltip: "Array iteration",
+		tooltip: "Loops throught every item of the given array.",
 		helpUrl: "",
 		code: (args) => {
 			return `for (let ${args.ITEM} of ${args.ARRAY}) {\n${args.INPUT}\n}`;
@@ -100,7 +100,7 @@ const blocks: BlockDefinition[] = [
 		shape: BlockShape.Action,
 		inline: true,
 		colour: rgbToHex(91, 165, 91),
-		tooltip: "Break",
+		tooltip: "Breaks out of a loop.",
 		helpUrl: "",
 		code: (args) => {
 			return `${args.ACTION};`;