Skip to content

Commit

Permalink
Merge branch 'scroll' into feat/scroll-alloy-provider
Browse files Browse the repository at this point in the history
Signed-off-by: Gregory Edison <[email protected]>
  • Loading branch information
greged93 committed Jan 28, 2025
2 parents efc886a + 34fbede commit c1f621a
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ jobs:
--exclude reth-e2e-test-utils --exclude reth-ethereum-payload-builder --exclude reth-exex-test-utils \
--exclude reth-node-ethereum --exclude reth-scroll-cli --exclude reth-scroll-evm \
--exclude reth-scroll-node --exclude scroll-reth --exclude reth-scroll-rpc --exclude reth-scroll-trie \
--exclude reth-scroll-engine-primitives
--exclude reth-scroll-engine-primitives --exclude scroll-alloy-provider
book:
name: book
Expand Down
18 changes: 15 additions & 3 deletions crates/scroll/alloy/provider/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ reth-provider = { workspace = true, features = ["test-utils"] }
reth-rpc-builder.workspace = true
reth-rpc-engine-api.workspace = true
reth-rpc-types-compat.workspace = true
reth-scroll-engine-primitives = { workspace = true, features = ["scroll"] }
reth-scroll-node = { workspace = true, features = ["scroll"] }
reth-scroll-engine-primitives.workspace = true
reth-scroll-node.workspace = true
reth-scroll-payload.workspace = true
reth-scroll-chainspec.workspace = true
reth-tasks.workspace = true
Expand All @@ -58,5 +58,17 @@ default = ["std"]
std = [
"alloy-primitives/std",
"alloy-rpc-types-engine/std",
"scroll-alloy-rpc-types-engine/std"
"scroll-alloy-rpc-types-engine/std",
"derive_more/std",
"reth-primitives/std",
"reth-primitives-traits/std",
]
scroll = [
"reth-scroll-node/scroll",
"reth-scroll-engine-primitives/scroll"
]
optimism = [
"reth-provider/optimism",
"reth-scroll-engine-primitives/optimism",
"reth-scroll-node/optimism"
]
3 changes: 1 addition & 2 deletions crates/scroll/alloy/provider/src/engine/provider.rs
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ impl ScrollAuthEngineApiProvider {
}
}

#[cfg(test)]
#[cfg(all(test, feature = "scroll", not(feature = "optimism")))]
mod tests {
use super::*;
use crate::engine::ScrollEngineApi;
Expand Down Expand Up @@ -84,7 +84,6 @@ mod tests {
handle
}

/// Localhost with port 0 so a free port is used.
const fn test_address() -> SocketAddr {
SocketAddr::V4(SocketAddrV4::new(Ipv4Addr::UNSPECIFIED, 0))
}
Expand Down
2 changes: 1 addition & 1 deletion crates/scroll/alloy/provider/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//! Providers implementations fitted for Scroll needs.
//! Providers implementations fitted to Scroll needs.
mod engine;
pub use engine::{JwtAuthHttpClient, ScrollAuthEngineApiProvider, ScrollEngineApi};

0 comments on commit c1f621a

Please sign in to comment.