Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: scroll mpt #107

Merged
merged 8 commits into from
Dec 27, 2024
Merged

feat: scroll mpt #107

merged 8 commits into from
Dec 27, 2024

Conversation

greged93
Copy link
Collaborator

Adds a binary and types to run a Scroll node with the MPT in place of the Binary MPT.

frisitano
frisitano previously approved these changes Dec 24, 2024
View reviewed changes
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! Left some minor remarks inline.

crates/engine/tree/Cargo.toml Outdated Show resolved Hide resolved
crates/scroll/bin/scroll-reth-mpt/src/main.rs Outdated Show resolved Hide resolved
crates/scroll/bin/scroll-reth/src/main.rs Outdated Show resolved Hide resolved
@greged93
answer comments
6fb4656 
Signed-off-by: Gregory Edison <[email protected]>
frisitano
frisitano approved these changes Dec 27, 2024
View reviewed changes
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! LGTM.

@frisitano frisitano merged commit 6942180 into scroll Dec 27, 2024
45 checks passed
@frisitano frisitano deleted the feat/scroll-mpt branch December 27, 2024 11:49
@frisitano frisitano mentioned this pull request Dec 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frisitano frisitano frisitano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greged93 @frisitano