Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scroll etherscan engine api #109

Merged
merged 9 commits into from
Dec 27, 2024
Merged

Conversation

greged93
Copy link
Collaborator

Fixes the debug client implementation to work with all versions of the execution payload and adds a correct implementation for the PayloadValidator for Scroll, ensuring a correct conversion from payload to sealed block.

@greged93 greged93 changed the title feat: etherscan consensus feat: scroll etherscan engine api Dec 26, 2024
@greged93 greged93 force-pushed the fix/etherscan-consensus branch from eb335b5 to d78c6cd Compare December 26, 2024 17:05
Signed-off-by: Gregory Edison <[email protected]>
@greged93 greged93 force-pushed the fix/etherscan-consensus branch from d78c6cd to 7e57738 Compare December 27, 2024 10:13
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! LGTM.

@frisitano frisitano merged commit d86f5ab into scroll Dec 27, 2024
45 checks passed
@frisitano frisitano deleted the fix/etherscan-consensus branch December 27, 2024 13:39
@frisitano frisitano mentioned this pull request Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants