fix: disconnect on PoW peer message #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Edison <[email protected]>
frisitano
requested changes
Dec 30, 2024
There was a problem hiding this comment.
I don't think the scroll feature flag is suitable here as it has implications for the state commitment types/operations. For example, the scroll feature flag is not compatible with the native mpt implementation.
I wonder if instead of introducing a feature flag we should see if we can modify the NetworkConfig to use PoW instead of PoS?
reth/crates/net/network/src/config.rs
Lines 70 to 71 in dba9746
Signed-off-by: Gregory Edison <[email protected]>
…on `NewBlock` and `NewBlockHashes` Signed-off-by: Gregory Edison <[email protected]>
greged93
force-pushed
the
fix/dropped-connections
branch
from
5290b30 to
50cadec
Compare
frisitano
approved these changes
Jan 7, 2025
|
we could sync the node via the L2 P2P before this change, but we were getting a lot of disconnects due to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid disconnecting peer on
NewBlockandNewBlockHashespeer messages. Feature flag the disconnect and simply log the block hash(es) when "scroll" feature is active.Resolves #99