Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix mpt sync #132

Closed
wants to merge 1 commit into from
Closed

chore: fix mpt sync #132

wants to merge 1 commit into from

Conversation

greged93
Copy link
Collaborator

@greged93 greged93 commented Jan 11, 2025

The code_size is used in extcodesize, and removing it from the Account lead to a default value value of 0 to be used for the field when retrieving an account from database and converting it to an revm::primitives::AccountInfo. This further lead to a sync error (gas used mismatch) at block 3404 because an incorrect code size of 0 was used.

In order to reenable syncing in the MPT mode without adding too much diff with upstream, we remove the code_size "shortcut" that is taken in the Scroll revm fork for the extcodesize, and instead retrieve the code from database and return its length as done in the latest commit on the scroll-evm-executor/reth/v51 branch.

Resolves #130

Signed-off-by: Gregory Edison <[email protected]>
Copy link

codspeed-hq bot commented Jan 11, 2025

CodSpeed Performance Report

Merging #132 will not alter performance

Comparing fix/sync-mpt (c5c0da4) with scroll (88e9188)

Summary

✅ 77 untouched benchmarks

Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the correct approach. CI seems to be failing, did you forget to add the updated workspace Cargo.toml file?

@greged93
Copy link
Collaborator Author

closed in favor of #133

@greged93 greged93 closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: sync failure on block 3404
2 participants