forked from paradigmxyz/reth
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore merge upstream b263b5c62 #146
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: DaniPopes <[email protected]>
…aradigmxyz#13804) Co-authored-by: Matthias Seitz <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
greged93
commented
Jan 24, 2025
greged93
commented
Jan 24, 2025
greged93
commented
Jan 24, 2025
greged93
commented
Jan 24, 2025
CodSpeed Performance ReportMerging #146 will not alter performanceComparing Summary
|
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
frisitano
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for this! Left a comment inline but not a blocker. LGTM
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the major changes done upstream related to how custom node types were added, this PR had to update quite a lot of the previous codebase and introduce various custom Scroll types.
This PR also bump revm to v54.
Unmerged paths: (use "git add/rm <file>..." as appropriate to mark resolution) both modified: .github/workflows/stage.yml both modified: Cargo.lock both modified: Cargo.toml both modified: bin/reth/src/commands/debug_cmd/in_memory_merkle.rs both modified: crates/chain-state/src/in_memory.rs both modified: crates/engine/tree/src/tree/mod.rs both modified: crates/optimism/bin/src/main.rs both modified: crates/optimism/consensus/Cargo.toml both modified: crates/optimism/payload/src/payload.rs both modified: crates/primitives-traits/Cargo.toml both modified: crates/primitives/Cargo.toml deleted by them: crates/primitives/src/alloy_compat.rs both modified: crates/primitives/src/block.rs both modified: crates/primitives/src/proofs.rs both modified: crates/primitives/src/receipt.rs both modified: crates/primitives/src/transaction/mod.rs both modified: crates/primitives/src/transaction/tx_type.rs both modified: crates/stages/stages/src/stages/merkle.rs both modified: examples/custom-beacon-withdrawals/Cargo.toml both modified: examples/custom-beacon-withdrawals/src/main.rs