Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip usage of ScrollPostExecutionContext #98

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

greged93
Copy link
Collaborator

@greged93 greged93 commented Dec 19, 2024

Comments the Poseidon code hashing of the account code hash. This should be uncommented once we replace the Scroll revm fork and adopt the sdk pattern introduced in revm.

Resolves #84

@greged93 greged93 force-pushed the feat/skip-post-execution-context branch from adbab23 to 61af6b4 Compare December 19, 2024 20:06
@frisitano frisitano assigned frisitano and unassigned frisitano Dec 19, 2024
@frisitano frisitano self-requested a review December 19, 2024 22:02
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. lgtm

@frisitano frisitano merged commit bb82d3b into scroll Dec 19, 2024
40 checks passed
@frisitano frisitano deleted the feat/skip-post-execution-context branch December 19, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long write_preparation_duration in ExecutionStage
2 participants