Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change call chain_monitor api #1026

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

georgehao
Copy link
Member

@georgehao georgehao commented Dec 7, 2023

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

change chain monitor api from v1 to v2

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@georgehao georgehao added the bump-version Bump the version tag for deployment label Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (144c7ed) 48.00% compared to head (f28ffd4) 48.03%.

❗ Current head f28ffd4 differs from pull request most recent head dbe1e36. Consider uploading reports for the commit dbe1e36 to get more accurate results

Files Patch % Lines
rollup/internal/controller/relayer/l2_relayer.go 62.50% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1026      +/-   ##
===========================================
+ Coverage    48.00%   48.03%   +0.02%     
===========================================
  Files          101      101              
  Lines        10671    10692      +21     
===========================================
+ Hits          5123     5136      +13     
- Misses        5120     5126       +6     
- Partials       428      430       +2     
Flag Coverage Δ
rollup 66.00% <62.50%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgehao georgehao merged commit 99454e5 into develop Dec 8, 2023
@georgehao georgehao deleted the feat/update_call_chain_monitor branch December 8, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants