Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor zkevm traits to support rc8 #1359

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

amoylan2
Copy link
Contributor

@amoylan2 amoylan2 commented Jun 5, 2024

Purpose or design rationale of this PR

Refactor zkevm-related traits to support v0.11.0rc8 (#1350)

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

prover_rust/src/types.rs Show resolved Hide resolved
@amoylan2
Copy link
Contributor Author

amoylan2 commented Jun 5, 2024

Will merge this PR, any problem will be fixed in refactor/prover branch.

@amoylan2 amoylan2 merged commit 76429e5 into refactor/prover Jun 5, 2024
1 check failed
@amoylan2 amoylan2 deleted the refactor/prover_rc8 branch June 5, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants