-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace golang prover with rust prover #1370
Conversation
In this PR, prover/core/prover_test.go is deleted. The current rust prover dir is not "feature equvalent" with old go prover, eg, no test codes like that. (or i don't know?) So before we merge this.. we'd better have another test like https://github.com/scroll-tech/test_zkp or https://github.com/scroll-tech/scroll/pull/1350/files#diff-35a75e70c44c1d18632302dd5f17902010968534c81f41a18caf5f1ed63e9a2f (non docker version). Infra should have some e2e testing codes so that once circuit team release a version, you have some method to ensure the new release is really ok in your setup, same with your usually data flow. |
Will do this in another PR in recent time. Since go prover is not used yet, the tests here seems not meaningful |
I think we can bump version for this PR as well. |
Purpose or design rationale of this PR
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated or have you addedbump-version
label to this PR?Breaking change label
Does this PR have the
breaking-change
label?