Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace golang prover with rust prover #1370

Merged
merged 7 commits into from
Jun 12, 2024
Merged

Conversation

amoylan2
Copy link
Contributor

@amoylan2 amoylan2 commented Jun 12, 2024

Purpose or design rationale of this PR

  • Remove go prover
  • Rename prover_rust to prover

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@amoylan2 amoylan2 requested review from georgehao and colinlyguo June 12, 2024 06:38
georgehao
georgehao previously approved these changes Jun 12, 2024
@lispc
Copy link
Contributor

lispc commented Jun 12, 2024

In this PR, prover/core/prover_test.go is deleted. The current rust prover dir is not "feature equvalent" with old go prover, eg, no test codes like that. (or i don't know?)

So before we merge this.. we'd better have another test like https://github.com/scroll-tech/test_zkp or https://github.com/scroll-tech/scroll/pull/1350/files#diff-35a75e70c44c1d18632302dd5f17902010968534c81f41a18caf5f1ed63e9a2f (non docker version).

Infra should have some e2e testing codes so that once circuit team release a version, you have some method to ensure the new release is really ok in your setup, same with your usually data flow.

@amoylan2
Copy link
Contributor Author

In this PR, prover/core/prover_test.go is deleted. The current rust prover dir is not "feature equvalent" with old go prover, eg, no test codes like that. (or i don't know?)

So before we merge this.. we'd better have another test like https://github.com/scroll-tech/test_zkp or https://github.com/scroll-tech/scroll/pull/1350/files#diff-35a75e70c44c1d18632302dd5f17902010968534c81f41a18caf5f1ed63e9a2f (non docker version).

Infra should have some e2e testing codes so that once circuit team release a version, you have some method to ensure the new release is really ok in your setup, same with your usually data flow.

Will do this in another PR in recent time. Since go prover is not used yet, the tests here seems not meaningful

@colinlyguo
Copy link
Member

I think we can bump version for this PR as well.

colinlyguo
colinlyguo previously approved these changes Jun 12, 2024
@colinlyguo colinlyguo added the bump-version Bump the version tag for deployment label Jun 12, 2024
@colinlyguo colinlyguo changed the title Replace prover feat: replace golang prover with rust prover Jun 12, 2024
@georgehao georgehao merged commit 874d3f2 into develop Jun 12, 2024
@georgehao georgehao deleted the replace_prover branch June 12, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants