Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(coordinator): upgrade 4 #1399

Merged
merged 52 commits into from
Jul 8, 2024
Merged

Conversation

georgehao
Copy link
Member

@georgehao georgehao commented Jun 26, 2024

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

Still need TODO:
[x] add bundle test. (need wait relevant method from rollup_relayer)

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 22.96512% with 265 lines in your changes missing coverage. Please review.

Project coverage is 53.63%. Comparing base (bc9bc5d) to head (174c1f3).

Files Patch % Lines
coordinator/internal/orm/bundle.go 0.00% 143 Missing ⚠️
coordinator/internal/orm/batch.go 0.00% 52 Missing ⚠️
coordinator/internal/types/auth.go 50.00% 14 Missing and 7 partials ⚠️
coordinator/internal/types/prover.go 0.00% 16 Missing ⚠️
coordinator/internal/orm/l2_block.go 0.00% 10 Missing ⚠️
coordinator/test/mock_prover.go 85.07% 9 Missing and 1 partial ⚠️
coordinator/internal/orm/chunk.go 0.00% 8 Missing ⚠️
coordinator/internal/orm/prover_task.go 16.66% 5 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           feat/upgrade4    #1399      +/-   ##
=================================================
- Coverage          54.29%   53.63%   -0.67%     
=================================================
  Files                158      158              
  Lines              12606    12670      +64     
=================================================
- Hits                6845     6796      -49     
- Misses              5193     5313     +120     
+ Partials             568      561       -7     
Flag Coverage Δ
bridge-history-api 72.50% <ø> (ø)
common 49.61% <ø> (+3.08%) ⬆️
coordinator 17.53% <22.96%> (-2.41%) ⬇️
database 42.85% <ø> (ø)
rollup 59.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgehao georgehao requested review from colinlyguo and amoylan2 and removed request for colinlyguo June 30, 2024 16:10
@georgehao georgehao changed the title (wip) feat(coordinator): upgrade 4 feat(coordinator): upgrade 4 Jun 30, 2024
@georgehao georgehao merged commit 380dbba into feat/upgrade4 Jul 8, 2024
16 checks passed
@georgehao georgehao deleted the feat/coordinator_upgrade_4 branch July 8, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants