feat(contracts): lido gateway #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LCOV of commit
|
Thegaram
previously approved these changes
Nov 8, 2023
|
Storage layouts (for reference): |
zimpha
changed the title
icemelon
reviewed
Dec 15, 2023
icemelon
reviewed
Dec 15, 2023
|
could you benchmark the gas cost of lido bridge? |
TheDZhon
reviewed
Dec 15, 2023
There was a problem hiding this comment.
Hello, thank you for all of the efforts, team 👍
Awesome work!
I want to add some input from the NEW tech wing side 🙏
Will get back to you by late Wednesday with more details; just decided to put forward major suggestions and proposals on the go to make things more agile
TheDZhon
reviewed
Dec 20, 2023
zimpha
commented
Dec 22, 2023
zimpha
commented
Dec 22, 2023
zimpha
commented
Dec 22, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #988 +/- ##
===========================================
+ Coverage 56.15% 56.45% +0.29%
===========================================
Files 145 149 +4
Lines 11014 11087 +73
===========================================
+ Hits 6185 6259 +74
+ Misses 4407 4406 -1
Partials 422 422
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
will do after rebasing with #1011 |
|
icemelon
previously approved these changes
Jan 16, 2024
Thegaram
previously approved these changes
Jan 16, 2024
Thegaram
approved these changes
Jan 16, 2024
icemelon
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or design rationale of this PR
This PR implements the Lido L1 and L2 Gateways.
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tagincommon/version.gobeen updated or have you addedbump-versionlabel to this PR?Breaking change label
Does this PR have the
breaking-changelabel?