Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ws client #831

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Deprecate ws client #831

merged 3 commits into from
Feb 4, 2025

Conversation

haerdib
Copy link
Contributor

@haerdib haerdib commented Feb 4, 2025

closes #817

@haerdib haerdib self-assigned this Feb 4, 2025
@haerdib haerdib added F1-security possible vulnerability E1-breaksnothing labels Feb 4, 2025
@haerdib haerdib changed the title Deprecated ws client Deprecate ws client Feb 4, 2025
@haerdib haerdib marked this pull request as ready for review February 4, 2025 12:03
@haerdib haerdib requested a review from Niederb February 4, 2025 12:03
Niederb
Niederb approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@Niederb Niederb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@haerdib haerdib merged commit 1f84409 into master Feb 4, 2025
57 checks passed
@haerdib haerdib deleted the bh/817-deprecated-ws-library branch February 4, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Niederb Niederb Niederb approved these changes

Assignees

@haerdib haerdib

Labels
E1-breaksnothing F1-security possible vulnerability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate websocket library
2 participants
@haerdib @Niederb