-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can now specify which 'layer' of the AnnData table to use #402
Conversation
…ing points using a table
This PR depends on scverse/spatialdata#818 |
Todo:
|
…/github.com/scverse/spatialdata-plot into feature/issue326-layer-selection-of-anndata
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
==========================================
+ Coverage 83.76% 83.83% +0.06%
==========================================
Files 8 8
Lines 1694 1732 +38
==========================================
+ Hits 1419 1452 +33
- Misses 275 280 +5
|
|
@LucaMarconato this PR is waiting for the next |
Yes, today 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added validation function, otherwise lgtm
Should solve #326
Plus: 2 bugfixes when coloring points by values in a table:
a) coloring by values in table.X didn't work before
b) Error when using the
groups
argument while the values to color by are stored in a table