Fix varint marshal, unmarshall
#309
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illia-li
force-pushed
the
il/fix/marshal/varint
branch
2 times, most recently
from
3ee15a2
to
6b215f1
Compare
dkropachev
requested changes
Oct 16, 2024
Comment on lines
+115
to
+134
| switch { | ||
| case byte(v>>63) != 0: | ||
| return []byte{0, byte(v >> 56), byte(v >> 48), byte(v >> 40), byte(v >> 32), byte(v >> 24), byte(v >> 16), byte(v >> 8), byte(v)} | ||
| case byte(v>>55) != 0: | ||
| return []byte{byte(v >> 56), byte(v >> 48), byte(v >> 40), byte(v >> 32), byte(v >> 24), byte(v >> 16), byte(v >> 8), byte(v)} | ||
| case byte(v>>47) != 0: | ||
| return []byte{byte(v >> 48), byte(v >> 40), byte(v >> 32), byte(v >> 24), byte(v >> 16), byte(v >> 8), byte(v)} | ||
| case byte(v>>39) != 0: | ||
| return []byte{byte(v >> 40), byte(v >> 32), byte(v >> 24), byte(v >> 16), byte(v >> 8), byte(v)} | ||
| case byte(v>>31) != 0: | ||
| return []byte{byte(v >> 32), byte(v >> 24), byte(v >> 16), byte(v >> 8), byte(v)} | ||
| case byte(v>>23) != 0: | ||
| return []byte{byte(v >> 24), byte(v >> 16), byte(v >> 8), byte(v)} | ||
| case byte(v>>15) != 0: | ||
| return []byte{byte(v >> 16), byte(v >> 8), byte(v)} | ||
| case byte(v>>7) != 0: | ||
| return []byte{byte(v >> 8), byte(v)} | ||
| default: | ||
| return []byte{byte(v)} | ||
| } |
There was a problem hiding this comment.
Why encUint64 and encUint are the same ?
There was a problem hiding this comment.
uint max bit size same as uint64 for 64-bit architectures
There was a problem hiding this comment.
exactly, why not to use same function ?
There was a problem hiding this comment.
Are inputs are different uint and uint64.
I don`t want to use unnecessary type convert.
illia-li
force-pushed
the
il/fix/marshal/varint
branch
3 times, most recently
from
12557fa
to
b063b8e
Compare
illia-li
force-pushed
the
il/fix/marshal/varint
branch
from
b063b8e
to
6edc349
Compare
illia-li
force-pushed
the
il/fix/marshal/varint
branch
from
6edc349
to
9a66efd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed for
varinttype:stringmarshal and unmarshal asnullable.1.1. Before: marshals
""- caused an error; unmarshalsnil datainto"0".1.2. Now: marshals and unmarshals
nil data-"".string(bigger thenmath.MaxInt64) marshal and unmarshal, beforenot supported, nowsupported.custom stringunmarshals, beforenot supported, nowsupported.go typesmarshals and unmarshal functions are optimized.math.MaxUint64, intouint64,uint, returnerrorbefore, nowno error.