Fix ascii marshal, unmarshall
#322
Open
+400
−131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylwiaszunejko
requested changes
Oct 28, 2024
illia-li
force-pushed
the
il/fix/marshal/ascii
branch
from
6d386e7
to
8e26db1
Compare
dkropachev
previously approved these changes
Oct 30, 2024
illia-li
force-pushed
the
il/fix/marshal/ascii
branch
from
8e26db1
to
6bc5d3e
Compare
dkropachev
previously approved these changes
Nov 7, 2024
|
@illia-li , can you please rebase it |
illia-li
force-pushed
the
il/fix/marshal/ascii
branch
2 times, most recently
from
0d759cc
to
ca3e918
Compare
dkropachev
requested changes
Nov 15, 2024
| } | ||
| v.SetBytes(decBytes(p)) | ||
| case reflect.Interface: | ||
| v.Elem().Set(reflect.ValueOf(decBytes(p))) |
There was a problem hiding this comment.
I am pretty sure that ascii, by default, should be serialized into string not into []byte
There was a problem hiding this comment.
text, blob, varchar cql types unmarshalls *interface{} as []byte
There was a problem hiding this comment.
I don't see any logic in old marshal that would inmarshal to interface, but here is the default behavior when it prepares rows:
func goType(t TypeInfo) (reflect.Type, error) {
switch t.Type() {
case TypeVarchar, TypeAscii, TypeInet, TypeText:
return reflect.TypeOf(*new(string)), nil
ca3e918
to
88e8914
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
zero datainto[]byte,*[]byte, returned([]byte)(nil)and(*[]byte)(*[nil])before, now returns([]byte)([])and(*[]byte)(*[])custom interface{}, was unsupported before, now is supported.