-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scylla-node: remove ignore_errors, make node exporter from 2022 work #324
base: master
Are you sure you want to change the base?
Conversation
I split away node exporter from #232 can you review @vladzcloudius or @igorribeiroduarte / @ebenzecri ? |
don't merge, I am trying to fix molecule |
9baabd4
to
a5093ff
Compare
ok, molecule should pass now so please re-review, or check above, this will get rid of ignore errors for node exporter and properly use it for any Scylla version now |
@vladzcloudius ping? |
This PR has conflicts, please, rebase. |
fix detection of legacy node-exporter services in case old node exporter is running it will block new one from starting so make sure old service is stopped before trying to run new one
rebased, but logic changed, I need to retest new condition
|
so basically classic situation when you have old 2021 Scylla and you upgrade needs to be retested with this new change |
2022 node exporter now works for clean install and upgrades
fix detection of node-exporter services
make sure the name of node exporter service matches the check