fix(cluster): use external_address in cql_ip_address #6382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace usage of ip_address with external_address as it more suitable for purpose to be a public address.
enaydanov
added
Ready for review
backport/5.2
|
I'll need more information here, where did we see an issue with this code, with siren ? I thought we were using VPC peering and not using public addresses ? Anyhow please run azure artifact test to validate this doesn't break it. |
|
Yes, siren-tests is the case when we use False for INTRA_NODE_COMM_PUBLIC and True for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the changes introduced in #6062 for the case if INTRA_NODE_COMM_PUBLIC is False.
Note, that it's not required to replace second occurrence of
ip_addresswithexternal_address.PR pre-checks (self review)
backportlabelsNew configuration option are added and documented (insdcm/sct_config.py)I have added tests to cover my changes (Infrastructure only - underunit-test/folder)