Update gke.md

[b8kings0ga]

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

[scylla-operator-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: b8kings0ga
Once this PR has been reviewed and has the lgtm label, please assign zimnx for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[scylla-operator-bot]

Hi @b8kings0ga. Thanks for your PR.

I'm waiting for a scylladb member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tnozicka]

Does sed -i -e "s/<gcp_region>/${GCP_REGION}/g;s/<gcp_zone>/${GCP_ZONE}/g" examples/gke/cluster.yaml" work on Mac?

[b8kings0ga]

yes,
sed -i -e "s/<gcp_region>/${GCP_REGION}/g;s/<gcp_zone>/${GCP_ZONE}/g" examples/gke/cluster.yaml"
works too

[tnozicka]

thx, then we can just update the existing one to work on both platforms

[b8kings0ga]

ok, I will update this

[ylebi]

sed -i -e "s/<gcp_region>/${GCP_REGION}/g;s/<gcp_zone>/${GCP_ZONE}/g" examples/gke/cluster.yaml"

Will not work on Mac. It will create a new cluster.yaml-e and also have too many quotes.

You can use:
sed -i '' 's/<gcp_region>/${GCP_REGION}/g;s/<gcp_zone>/${GCP_ZONE}/g' examples/gke/cluster.yaml
or
sed -i '' -e 's/<gcp_region>/${GCP_REGION}/g;s/<gcp_zone>/${GCP_ZONE}/g' examples/gke/cluster.yaml

Additional information:
https://stackoverflow.com/questions/4247068/sed-command-with-i-option-failing-on-mac-but-works-on-linux/4247319#4247319

[tnozicka]

not sure how the ending quote got into my answer but you need double quotes to substitute the variables - thanks for the -i difference explanation

[scylla-operator-bot]

The Scylla Operator project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 30d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out

/lifecycle stale