codewide: small performance optimisations #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In multiple places in the code, `format!` is called only to subsequently pass the allocated String to a printing macro. In all such places, `format!` could be trivially elided.
|
|
Instead of allocating a `Vec<_>`, one can leverage `CommaSeparatedDisplayer` to print a series of items in the comma-separated manner.
RequestSpan::record_replicas now: 1. accepts an iterator, not necessarily a slice, 2. utilises CommaSeparatedDisplayer instead of hand-crafted comma management. In the next commit, the point 1. is taken advantage of.
Even though the replicas were allocated in a SmallVec, with the enhanced RequestSpan::record_replicas implementation we can elide the call to `collect()`. In order to make this possible, several iterators in the replica locator have now `Clone` derived.
Perhaps the compiler would optimise this anyway, but now it's explicitly better.
This is a tiny optimisation.
wprzytula
force-pushed
the
small-optimisations
branch
from
7225d4b to
a42992f
Compare
muzarski
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bunch of tiny optimisations around reducing number of allocations.
Pre-review checklist
[ ] I added relevant tests for new features and bug fixes.[ ] I have provided docstrings for the public items that I want to introduce.[ ] I have adjusted the documentation in./docs/source/.[ ] I added appropriateFixes:annotations to PR description.