Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm64: dts: qcom: sdm636-xiaomi-tulip: enable fan53526 buck regulator for LDDR4 #45

Open
wants to merge 2 commits into
base: qcom-sdm660-6.11.y
Choose a base branch
from

Conversation

M0Rf30
Copy link

@M0Rf30 M0Rf30 commented Nov 9, 2024

From what I've found this regulator is in lavender, clover and tulip schematics.

dmesg:

[   24.306635] fan53555-regulator 1-0060: FAN53555 Option[8] Rev[1] Detected!
[   24.306887] fan53555-reg: Bringing 618750uV into 1000000-1000000uV

i2c-detect:

xiaomi-tulip:~$ sudo i2cdetect -r 1
WARNING! This program can confuse your I2C bus, cause data loss and worse!
I will probe file /dev/i2c-1 using receive byte commands.
I will probe address range 0x08-0x77.
Continue? [Y/n] y
     0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f
00:                         -- -- -- -- -- -- -- --
10: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
20: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
30: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
40: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
50: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
60: UU -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
70: -- -- -- -- -- -- -- --

This specific version is used on sdm660 SoC family

Signed-off-by: Gianluca Boiano <[email protected]>
Copy link
Member

@minlexx minlexx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does linux need to know anything about this regulator though? if DDR was not powered, nothing would work, no? maybe primary BL already sets it up? Especially if this regulator is always-on 🤔

arch/arm64/boot/dts/qcom/sdm636-xiaomi-tulip.dts Outdated Show resolved Hide resolved
arch/arm64/boot/dts/qcom/sdm636-xiaomi-tulip.dts Outdated Show resolved Hide resolved
@minlexx
Copy link
Member

minlexx commented Nov 9, 2024

Also I thought, this is the power to DDR - https://elixir.bootlin.com/linux/v6.11.7/source/arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi#L541

		/* This gives power to the LPDDR4: never turn it off! */
		vreg_l13a_1p8: l13 {

or maybe it can be device specific 🤔

@M0Rf30 M0Rf30 force-pushed the qcom-sdm660-6.11.y-FAN53526 branch from 2bb5c6d to cde75bc Compare November 9, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants