Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.13 #447

Merged
merged 8 commits into from
Jan 10, 2025
Merged

Support Python 3.13 #447

merged 8 commits into from
Jan 10, 2025

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Jan 9, 2025

Addresses #434

@rwedge rwedge requested review from fealho and amontanez24 January 9, 2025 21:14
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.11%. Comparing base (38e7d45) to head (dd5d706).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #447   +/-   ##
=======================================
  Coverage   90.11%   90.11%           
=======================================
  Files          29       29           
  Lines        1821     1821           
=======================================
  Hits         1641     1641           
  Misses        180      180           
Flag Coverage Δ
integration 79.73% <ø> (ø)
unit 86.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rwedge
Copy link
Contributor Author

rwedge commented Jan 9, 2025

We'll need to update the merge rules to expect "unit (macos-latest, 3.13)" instead of "unit (macos-latest, 3.12)"

Copy link
Member

@fealho fealho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tox.ini also needs to be updated.

@rwedge rwedge force-pushed the issue-434-support-py313 branch from cbbb50b to dd5d706 Compare January 10, 2025 15:03
Comment on lines 1 to 5
[tox]
envlist = py39-lint, py3{8,9,10,11,12}-{readme,unit,end_to_end,numerical,minimum,tutorials}
envlist = py39-lint, py3{8,9,10,11,12,13}-{readme,unit,end_to_end,numerical,minimum,tutorials}

[testenv]
skipsdist = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can delete tox.ini i think we are not using tox anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe that could be a separate issue since we mention tox in the makefile, contributing documentation, etc.

@rwedge rwedge merged commit 877fbd2 into main Jan 10, 2025
65 checks passed
@rwedge rwedge deleted the issue-434-support-py313 branch January 10, 2025 19:41
@rwedge rwedge mentioned this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants