-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addresses UR5 model display issue #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Few things for initial review:
- Thanks for fixing those docs API sections. Would you be willing to split that into a separate PR?
- You can just delete that UR5 example and leave the UR10
- The UR on base example at https://github.com/sea-bass/pyroboplan/blob/main/examples/differential_ik_whole_body.py will also need to be updated for the UR10.
@@ -25,6 +25,14 @@ pyroboplan.models.two\_dof module | |||
:undoc-members: | |||
:show-inheritance: | |||
|
|||
pyroboplan.models.ur5 module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should ur10 now also be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out. I am fixing the docs in a separate PR and will address this issue there.
If all the changes are okay, I will submit another PR to fix the documentation after your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the examples and they work and look great -- thank you!
Thanks for pointing out typos. Now its fixed. As discussed, I have added another PR #80 for fixing docs. |
This PR addresses the issue of the UR5 model display.
ur10
model to theur_description
directory.ur5_description
and updatedur_description
to accommodate all UR models.