Skip to content

Commit

Permalink
Remove generation of empty responses, since it is unused.
Browse files Browse the repository at this point in the history
  • Loading branch information
Sean Cribbs committed Jan 2, 2014
1 parent 7d2c742 commit ec07077
Showing 1 changed file with 0 additions and 16 deletions.
16 changes: 0 additions & 16 deletions msgcodegen.py
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ class build_messages(Command):
# Used in loading and generating
_pb_imports = set()
_messages = set()
_empty_responses = set()
_linesep = os.linesep
_indented_item_sep = ',{0} '.format(_linesep)

Expand Down Expand Up @@ -163,15 +162,12 @@ def _load(self):
message = MessageCodeMapping(*row)
self._messages.add(message)
self._pb_imports.add(message.module_name)
if message.message_class is None:
self._empty_responses.add(message)

def _generate(self):
self._contents = []
self._generate_doc()
self._generate_imports()
self._generate_codes()
self._generate_empties()
self._generate_classes()
write_file(self.destination, self._contents)

Expand All @@ -192,18 +188,6 @@ def _generate_codes(self):
self._contents.append("{0} = {1}".format(message.message_code_name,
message.code))

def _generate_empties(self):
# Write empty responses
names = [message.message_code_name
for message in sorted(self._empty_responses)]
items = self._indented_item_sep.join(names)
self._contents.extend(['',
"# These responses don't include messages",
'EMPTY_RESPONSES = [',
' ' + items,
']'
])

def _generate_classes(self):
# Write message classes
classes = [self._generate_mapping(message)
Expand Down

0 comments on commit ec07077

Please sign in to comment.