Reimplement main aspect of assertEqualXMLStructure #4507
+38
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #4091, there is a valid use case for having an assertion ensuring two DOM sub trees are structurally identical.
This PR re-implements the main aspect of the original, deprecated
assertEqualXMLStructure
: The comparison of two XML trees for structural identicality.Two DOM trees are to be considered identical when, after canonicalization, the following holds true:
Looking at the options of the original, deprecated method, this appears to be stricter. The original method for instance ignored namespace defining attributes as well as textual content.
As I didn't see a use case for that, I did not reimplement that aspect. My implementation basically ignores any whitespace and, due to canonicalization, reorders attributes as needed so the order of attributes is not relevant.
The name
assertDOMTreesEqualStructurally
is subject to change, only pending a better naming suggestion. It should probably reflect the actual assertion better.