Skip to content

Commit

Permalink
Merge pull request #1094 from noopurintel/noopur/round-check
Browse files Browse the repository at this point in the history
Logging fix - No of rounds saved vs started
  • Loading branch information
teoparvanov authored Oct 22, 2024
2 parents 0e8b25a + 7933bdc commit c9b02fe
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/pytest_coverage.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
# This workflow will install Python dependencies, run tests and lint with a single version of Python
# This workflow will run code coverage
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions

name: Pytest and code coverage

on:
pull_request:
branches: [ develop ]
workflow_dispatch:

permissions:
contents: read
Expand Down
9 changes: 5 additions & 4 deletions openfl/component/aggregator/aggregator.py
Original file line number Diff line number Diff line change
Expand Up @@ -968,16 +968,17 @@ def _end_of_round_check(self):

# Once all of the task results have been processed
self._end_of_round_check_done[self.round_number] = True

# Save the latest model
self.logger.info("Saving round %s model...", self.round_number)
self._save_model(self.round_number, self.last_state_path)

self.round_number += 1
# resetting stragglers for task for a new round
self.stragglers = []
# resetting collaborators_done for next round
self.collaborators_done = []

# Save the latest model
self.logger.info("Saving round %s model...", self.round_number)
self._save_model(self.round_number, self.last_state_path)

# TODO This needs to be fixed!
if self._time_to_quit():
self.logger.info("Experiment Completed. Cleaning up...")
Expand Down

0 comments on commit c9b02fe

Please sign in to comment.