Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MD5 hashing to SHA256 for Interactive API examples #1114

Closed

Conversation

theakshaypant
Copy link
Collaborator

Context

  • MD5 hashing may allow an attacker to produce collisions on the hash or execute length extension attacks. (CWE-328)
  • SHA-2 family hash functions are strong, well-vetted cryptographic hash functions that are currently not known to suffer these weaknesses.
  • This PR fixes a weakness identified by Coverity.

Affected examples

Changed hashlib.md5 to hashlib.sha256.

@teoparvanov
Copy link
Collaborator

teoparvanov commented Nov 4, 2024

Hi @theakshaypant , were you able to successfully run the examples (both before and after the fixes)? If so, please add a "Testing done" section in your PR description.

@theakshaypant theakshaypant marked this pull request as draft November 5, 2024 04:55
@rahulga1
Copy link
Collaborator

Closing as we wont be fixing any security issues in tutorials and examples folder.

@rahulga1 rahulga1 closed this Nov 18, 2024
@theakshaypant theakshaypant deleted the fix/risky-hash branch November 29, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants