Fix for tensor_db get_aggregated_tensor returns tuple in corner case 1087 #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yes <[email protected]>
tanwarsh
requested review from
psfoley,
theakshaypant,
MasterSkepticista,
rahulga1,
kta-intel,
rajithkrishnegowda and
ishaileshpant
Signed-off-by: yes <[email protected]>
rahulga1
approved these changes
Nov 5, 2024
Signed-off-by: yes <[email protected]>
|
My impression was that this scenario: aggregator calling get_aggregated_tensor on a tensor that has already been aggregated should not occur in normal conditions. For e.g. this may happen when there is an undesired behavior due to which aggregator is performing the aggregation twice. In this case I found that the existing functionality of returning a tuple + subsequent exception actually helps catch undesired behavior in the system Can you please clarify if there are use cases where this is an intended behavior ? |
nisha987
approved these changes
Nov 6, 2024
|
@tanwarsh Could you provide a MWE for this bug? |
|
Closing this PR following #1087 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the bug
Calling get_aggregated_tensor on a tensor that has already been aggregated returns a tuple of (tensor, {}).
For more information please refer #1087
Reproduced by calling get_aggregated_tensor twice from aggregator while running experiment with 2 collaborators.
Before:
After:
