Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaskRunner E2E Workflow: corrections and enhancements #1157

Closed
wants to merge 0 commits into from

Conversation

noopurintel
Copy link
Contributor

@noopurintel noopurintel commented Nov 19, 2024

  1. To print summary and collect logs in all the cases, irrespective of the previous step outcome.
  2. Pytest command on multi-line for better readability
  3. Failure reason along with status as part of GitHub summary.

Successful run (barring two failures due to connectivity issues between aggregator and a collaborator) -
https://github.com/noopurintel/openfl/actions/runs/11913562355

Latest run - https://github.com/noopurintel/openfl/actions/runs/11927010001

@noopurintel noopurintel marked this pull request as draft November 19, 2024 12:14
@noopurintel noopurintel marked this pull request as ready for review November 19, 2024 13:28
@noopurintel noopurintel changed the title TaskRunner E2E Workflow - corrections TaskRunner E2E Workflow: corrections and enhancements Nov 19, 2024
Copy link
Collaborator

@teoparvanov teoparvanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@noopurintel noopurintel marked this pull request as draft November 20, 2024 04:41
@noopurintel noopurintel marked this pull request as ready for review November 20, 2024 04:56
@noopurintel
Copy link
Contributor Author

There was a problem with commit sign-off where the commit was from last month. So I had to close this PR and create a new -#1161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants