Reorganization of OpenFL Experimental Directory Structure #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: refai06 <[email protected]>
Signed-off-by: refai06 <[email protected]>
Signed-off-by: refai06 <[email protected]>
Signed-off-by: refai06 <[email protected]>
Signed-off-by: refai06 <[email protected]>
Signed-off-by: refai06 <[email protected]>
…date-dir-structure
Signed-off-by: refai06 <[email protected]>
Signed-off-by: refai06 <[email protected]>
|
@refai06, thanks for taking a stab at this effort! Unfortunately, I think this PR has become too big, and I'd suggest to split it in two:
WDYT? |
…date-dir-structure
Signed-off-by: refai06 <[email protected]>
teoparvanov
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
I am approving this PR after an offline discussion where I gained a better understanding of the motivation behind the proposed changes. One of the benefits of moving the current set of Workflow API tutorials under openfl-tutorials/workflow/LocalRuntime is to accommodate for the upcoming ones under openfl-tutorials/workflow/FederatedRuntime.
teoparvanov
reviewed
Nov 22, 2024
openfl-tutorials/experimental/workflow/LocalRuntime/workflow_interface_requirements.txt
Outdated
Show resolved
Hide resolved
Signed-off-by: refai06 <[email protected]>
Signed-off-by: refai06 <[email protected]>
Signed-off-by: refai06 <[email protected]>
teoparvanov
approved these changes
Nov 28, 2024
teoparvanov
merged commit a26bdb2
into
securefederatedai:develop
27 of 29 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This PR aims to reorganize the OpenFL experimental directory structure for improved clarity and maintainability.
Description of Changes:
openfl/experimentalhave been moved toopenfl/experimental/workflowopenfl-tutorial/experimentaldirectory has been restructured intoopenfl-tutorial/experimental/workflowopenfl-workspace/experimentaldirectory has been restructured intoopenfl-workspace/experimental/workflow/AggregatorBasedWorkflowtests/github/experimentaldirectory has been reorganized intotests/github/experimental/workflow/LocalRuntimefor LocalRuntime.tests/github/experimental/workspace/directory has been reorganized intotests/github/experimental/workflow/AggregatorBasedWorkflowfor AggregatorBasedWorkflow.FederatedRuntimewill be addressed in a separate PR.Verification:
Following verification has been performed
All test cases have been verified and are working as expected.
tests/github/experimental/workflow/LocalRuntimetests/github/experimental/workflow/AggregatorBasedWorkflowFollowing LocalRuntime tutorials are executed (
openfl-tutorial/experimental/workflow)Following Aggregator Based Workflow tutorials are executed
(
openfl-workspace/experimental/workflow/AggregatorBasedWorkflow)Desktop: