Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaskRunner E2E: Parameterised input and coverity fix #1299

Merged
merged 39 commits into from
Jan 23, 2025

Conversation

noopurintel
Copy link
Contributor

@noopurintel noopurintel commented Jan 23, 2025

Parameterised the input for job, model and python version in TaskRunner E2E for better manual triggers.

image

Also, added a check on the fetched value of GITHUB_STEP_SUMMARY before using it - as part of Coverity fix.

Successful E2E job runs:

  1. All tests + keras_cnn_mnist + python 3.12 -> https://github.com/noopurintel/openfl/actions/runs/12922201062
  2. Test without TLS + torch_cnn_mnist+ python 3.11 -> https://github.com/noopurintel/openfl/actions/runs/12922184838
  3. All tests + models + python versions (just like existing flow) -> https://github.com/noopurintel/openfl/actions/runs/12922444478

Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
@noopurintel noopurintel marked this pull request as draft January 23, 2025 04:05
@noopurintel noopurintel marked this pull request as ready for review January 23, 2025 04:26
@rahulga1 rahulga1 merged commit 22e7dab into securefederatedai:develop Jan 23, 2025
22 checks passed
@noopurintel noopurintel deleted the noopur/summary-helper branch January 23, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants