-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incorporating support for federated evaluation #897
incorporating support for federated evaluation #897
Conversation
Signed-off-by: kta-intel <[email protected]>
Signed-off-by: kta-intel <[email protected]>
Signed-off-by: kta-intel <[email protected]>
Signed-off-by: kta-intel <[email protected]>
Signed-off-by: kta-intel <[email protected]>
5cfe878
to
c4b5ef4
Compare
@kta-intel the federated evaluation documentation you've added here is excellent. Can you confirm that the page is indexed correctly (i.e. shown on the side pane when you build locally)? If so this is ready to merge. |
Signed-off-by: kta-intel <[email protected]>
Great catch! I added it under the manual tab. Let me know if this looks good or if you think it should be added elsewhere instead. It builds locally without issue |
Thanks for the quick turnaround Kevin. manual is a good spot for the documentation. Only items remaining are 3 minor linting errors. Once those are fixed this can be merged. |
Signed-off-by: kta-intel <[email protected]>
* initialize federated evaluation document Signed-off-by: kta-intel <[email protected]> * add workspace for federated evaluation Signed-off-by: kta-intel <[email protected]> * Update federated_evaluation.rst Signed-off-by: kta-intel <[email protected]> * Update federated_evaluation.rst Signed-off-by: kta-intel <[email protected]> * Add comments to plan.yaml Signed-off-by: kta-intel <[email protected]> * indexing federated evaluation page under manual Signed-off-by: kta-intel <[email protected]> * fixing lint issues Signed-off-by: kta-intel <[email protected]> --------- Signed-off-by: kta-intel <[email protected]> Signed-off-by: manuelhsantana <[email protected]>
Request: #788
This PR adds an additional workspace template for federated evaluation using
torch_cnn_mnist
as a baseChanges made to
plan/plan.yaml
to setrounds_to_train
to 1 and setaggregator_model_validation
as the only task to be executedChanges made to
src/pt_cnn.py
to remove optimizer initialization and loss function, which are no longer needed for a single inference runAdded .rst file to docs to introduce federated eval and walk through example (Note: landing page TBD)