Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorporating support for federated evaluation #897

Conversation

kta-intel
Copy link
Collaborator

Request: #788

This PR adds an additional workspace template for federated evaluation using torch_cnn_mnist as a base

Changes made to plan/plan.yaml to set rounds_to_train to 1 and set aggregator_model_validation as the only task to be executed

Changes made to src/pt_cnn.py to remove optimizer initialization and loss function, which are no longer needed for a single inference run

Added .rst file to docs to introduce federated eval and walk through example (Note: landing page TBD)

@kta-intel kta-intel force-pushed the kta-intel/torch_cnn_mnist_fed_eval branch from 5cfe878 to c4b5ef4 Compare November 27, 2023 21:39
@psfoley
Copy link
Contributor

psfoley commented Jan 4, 2024

@kta-intel the federated evaluation documentation you've added here is excellent. Can you confirm that the page is indexed correctly (i.e. shown on the side pane when you build locally)? If so this is ready to merge.

@kta-intel
Copy link
Collaborator Author

@kta-intel the federated evaluation documentation you've added here is excellent. Can you confirm that the page is indexed correctly (i.e. shown on the side pane when you build locally)? If so this is ready to merge.

Great catch! I added it under the manual tab. Let me know if this looks good or if you think it should be added elsewhere instead. It builds locally without issue

@psfoley
Copy link
Contributor

psfoley commented Jan 5, 2024

Thanks for the quick turnaround Kevin. manual is a good spot for the documentation. Only items remaining are 3 minor linting errors. Once those are fixed this can be merged.

Signed-off-by: kta-intel <[email protected]>
@psfoley psfoley self-requested a review January 5, 2024 23:44
@psfoley psfoley merged commit f1657ab into securefederatedai:develop Jan 5, 2024
26 checks passed
manuelhsantana pushed a commit that referenced this pull request Jul 10, 2024
* initialize federated evaluation document

Signed-off-by: kta-intel <[email protected]>

* add workspace for federated evaluation

Signed-off-by: kta-intel <[email protected]>

* Update federated_evaluation.rst

Signed-off-by: kta-intel <[email protected]>

* Update federated_evaluation.rst

Signed-off-by: kta-intel <[email protected]>

* Add comments to plan.yaml

Signed-off-by: kta-intel <[email protected]>

* indexing federated evaluation page under manual

Signed-off-by: kta-intel <[email protected]>

* fixing lint issues

Signed-off-by: kta-intel <[email protected]>

---------

Signed-off-by: kta-intel <[email protected]>
Signed-off-by: manuelhsantana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants