-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp StartupPage Readme #919
Conversation
|
@nammbash please see my comments. thanks |
Looks good to me. I was able to run end to end. Thanks |
@psfoley @kta-intel @manuelhsantana @ifahim Requesting re-review of the readme startup documentation. |
c02b70c
to
67db64e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, Niroop! The updated quick start guide is very clear and easy to follow. I especially like the sample output. I only have two minor fixes, but other than that, this looks good to me
24c140a
to
02076b3
Compare
15f2717
to
17c86fd
Compare
Signed-off-by: nammbash <[email protected]>
Update README.md with new FL Plan Link Signed-off-by: nammbash <[email protected]>
3d6a336
to
86995a3
Compare
looks like there was a major merge to the develop branch. So I rebased, remade this PR to remove conflicts @psfoley @kta-intel @manuelhsantana |
Type of Change
Documentation
Description
The Startup Page readme documentation revamped for faster adoption for developers.
Changes include the following:
Expected Behavior & Potential Risk
Change shouldn't affect any code and should pose no risk.
How has this PR been tested?
Local tested on ICX server.
Dependency Change?
None.