-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mdBook page-toc test. #96
Open
mattaereal
wants to merge
14
commits into
develop
Choose a base branch
from
mddBook-pagetoc
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add SEAL logo as favicon * docs: Update README ##pull-requests * fix: Fix typo * fix: typos in pr_template * feat: improved tag generation * feat: Update tag display system * Sort tags alphabetically * Remove "Selected Articles" * When a tag is displayed, only show articles matching the tag * Fixed CSS on tags-dropdown * feat: remove duplicate code & document methods * Functionality remains, as far as I can tell, the same. I mostly just removed a few duplicate methods related to tagsList and added documentation to make the code easier for new readers. * refactor: move JS and CSS to seperate files * style: Added margin around page-tags * refactor: Extract tag initialization logic into seperate methods * fix: announcement-stripe overflowing at lower horizontal resolutions Also fixed layering issue due to background transparency * feat: implemented AND selection for tags. The code for OR selection was just commented out since I'm not sure if others actually wanted this, or if it was just me. Can be reverted if so desired. * feat: remove HTML styling on tag-search Better to have all styles in the .css file * Updating wordlist.txt and some markdown linting fixes * Jump of line fix in README * Updating wordlist * Adding a few more words to wordlist.txt * feat: Bookmarks (#83) * feat: add bookmarked to tags filtering * revert: remove bookmarked section from ToC I don't like how it looks & think being able to filter by bookmarked is probably sufficient. Slightly harder to learn, but once you do learn it's just as easy and has more features. * fix: Fix bug where deselcting tags removes all filters * fix: refresh sidebar when bookmarking Updates the sidebar links when filtering by Bookmarked --------- Co-authored-by: Mehdi Zerouali <[email protected]> Co-authored-by: Robert MacWha <[email protected]> Co-authored-by: Fredrik Svantes <[email protected]>
Co-authored-by: Robert MacWha <[email protected]>
Co-authored-by: Robert MacWha <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frameworks PR Checklist
Thank you for contributing to the Security Frameworks! Before you open a PR, make sure to read information for contributors and take a look at the following checklist:
Per the suggestion of @Robert-MacWha, I am testing out this repo. Leaving here in case we decide it works and we like it. https://github.com/JorelAli/mdBook-pagetoc
I like this approach because it does not need a preprocessor, but right now I can't make it work.