Add pylint to CI pipeline

seemoo-lab · Dec 2, 2020 · adb658d · adb658d
1 parent 91e204f
commit adb658d
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 2 deletions.
diff --git a/.github/workflows/testpackage.yml b/.github/workflows/testpackage.yml
@@ -34,6 +34,10 @@ jobs:
       run: |
         pip install flake8
         flake8 . --count --show-source --statistics
+    - name: Lint with pylint
+      run: |
+        pip install pylint
+        pylint --rcfile=setup.cfg opendrop
     - name: Test with pytest
       run: |
         pip install pytest

diff --git a/Makefile b/Makefile
@@ -1,9 +1,9 @@
-.PHONY: ci checkformat lint test autoformat
+.PHONY: ci checkformat isort lint pylint test autoformat
 
 VENV=venv
 PYTHON=$(VENV)/bin/python3
 
-ci: isort checkformat lint test
+ci: isort checkformat lint pylint test
 
 $(VENV): $(VENV)/bin/activate
 
@@ -23,6 +23,9 @@ checkformat: $(VENV)
 lint: $(VENV)	
 	$(PYTHON) -m flake8 . --count --show-source --statistics --exclude $(VENV)
 
+pylint: $(VENV)
+	$(PYTHON) -m pylint --rcfile=setup.cfg opendrop
+
 isort: $(VENV)
 	$(PYTHON) -m isort -c opendrop/**.py
 

diff --git a/requirements-dev.txt b/requirements-dev.txt
@@ -2,4 +2,5 @@ black
 flake8
 flake8-bugbear
 isort
+pylint
 pytest
diff --git a/setup.cfg b/setup.cfg
@@ -12,3 +12,6 @@ use_parentheses = True
 ensure_newline_before_comments = True
 line_length = 88
 
+[pylint]
+disable = C, R, W0511
+max-line-length = 88
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,4 +2,5 @@ black @@
     flake8
     flake8-bugbear
     isort
+    pylint
     pytest